-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MS 780] App improvements #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05653fb
to
673779a
Compare
673779a
to
0a1e921
Compare
ec4374a
to
7c7fc47
Compare
7c7fc47
to
38f5bc5
Compare
57892b7
to
f553101
Compare
f553101
to
fdcf764
Compare
JanChodorowski
approved these changes
Oct 16, 2024
// Proxy events has invalid types. | ||
const data = JSON.parse((record as any).Body); | ||
|
||
return data as SerializedPayload; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remember to properly parse runtime value
piotrgrundas
added a commit
that referenced
this pull request
Oct 24, 2024
* [MS-780] feat: Fix commands. Add send-notification tests * [MS-780] feat: Bump to fastify v5 * [MS-780] feat: Add sentry * [MS-780] feat: Bump libs * [MS-780] chore: Update readme * [MS-780] feat: Add webhooks tests * [MS-780] feat: More tests. Coverage setup * [MS-780] ci: Improve CI * [MS-780] feat: More tests
piotrgrundas
added a commit
that referenced
this pull request
Nov 6, 2024
* [MS-780] feat: Fix commands. Add send-notification tests * [MS-780] feat: Bump to fastify v5 * [MS-780] feat: Add sentry * [MS-780] feat: Bump libs * [MS-780] chore: Update readme * [MS-780] feat: Add webhooks tests * [MS-780] feat: More tests. Coverage setup * [MS-780] ci: Improve CI * [MS-780] feat: More tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: